Update template to use RR7 app template and Polaris web components#639
Update template to use RR7 app template and Polaris web components#639davejcameron merged 3 commits intomainfrom
Conversation
lizkenyon
force-pushed
the
update-payment-customization-rr7-template
branch
from
ba457d0 to
037a781
Compare
byrichardpowell
left a comment
byrichardpowell
left a comment
There was a problem hiding this comment.
@davejcameron please can you or team review the UI/UX changes?
| <link | ||
| rel="stylesheet" | ||
| href="https://cdn.shopify.com/static/fonts/inter/v4/styles.css" | ||
| /> |
| } | ||
|
|
||
| li { | ||
| .list > li { |
There was a problem hiding this comment.
Why change from element selectors to classes? I get why it's better, but just want to understand if thisis related/unrelated to RR. I think unrelated?
|
The weird part is the button on the title bar with Payment customizations, I don't think that'd be what we want. |
| Text, | ||
| VerticalStack, | ||
| } from "@shopify/polaris"; | ||
| import { TitleBar } from "@shopify/app-bridge-react"; |
There was a problem hiding this comment.
Should we use https://shopify.dev/docs/api/app-bridge-library/web-components/ui-title-bar instead then at least we are all web components
There was a problem hiding this comment.
Yes, I actually just brought this up to Richard. I think it makes sense for us to use all web components. @byrichardpowell if you are aligned I will update here and in the template.
| @@ -54,10 +39,10 @@ export const loader = async ({ params, request }) => { | |||
| responseJson.data.paymentCustomization?.metafield?.value && | |||
There was a problem hiding this comment.
Unrelated to your work, but I wish this used jsonValue rather than .value
lizkenyon
force-pushed
the
update-payment-customization-rr7-template
branch
from
037a781 to
a16b5ee
Compare
@davejcameron I updated it to use the contextual save bar, with bread crumbs. Which I more inline with what is outlined in the patterns doc. 
|
lizkenyon
force-pushed
the
update-payment-customization-rr7-template
branch
from
13fb002 to
23a776c
Compare
lizkenyon
force-pushed
the
update-payment-customization-rr7-template
branch
from
f6c83d4 to
e571dcb
Compare
davejcameron
changed the title
3 participants
What is this PR doing
Functions UI Before
Functions UI After